16 bit color depth bug with NVIDIA card

The following warnings occurred:

Warning [2] Undefined property: MyLanguage::$archive_pages - Line: 2 - File: printthread.php(287) : eval()'d code PHP 8.2.26 (Linux)

File	Line	Function
/inc/class_error.php	153	errorHandler->error
/printthread.php(287) : eval()'d code	2	errorHandler->error_callback
/printthread.php	287	eval
/printthread.php	117	printthread_multipage

16 bit color depth bug with NVIDIA card - Printable Version

+- EmuNewz Network (https://www.emunewz.net/forum)
+-- Forum: PSP Emulation (https://www.emunewz.net/forum/forumdisplay.php?fid=191)
+--- Forum: JPCSP Official Forum (https://www.emunewz.net/forum/forumdisplay.php?fid=51)
+---- Forum: svn trunk discussion (https://www.emunewz.net/forum/forumdisplay.php?fid=56)
+---- Thread: 16 bit color depth bug with NVIDIA card (/showthread.php?tid=156589)

Pages: 1 2

16 bit color depth bug with NVIDIA card - onelight - 01-17-2014

My friend gdmk tell me something wrong with GVG NEXT PLUS
This game is use 32 bit color depth, but jpcsp use 16bit color depth.
This bug just found in NVIDIA card
jpcsp 16 bit color depth

PPSSPP use 32 bit color depth

Kingdom Hearts Birth by Sleep Final Mix which game allow you choose 16 bit color depth or 32 bit color depth

16 bit color depth

32 bit color depth, true color

so gdmk suggest jpcsp use 32 bit color depth defualt also.

btw PPSPP run Kingdom Hearts Birth by Sleep Final Mix so good ,and the Texture Scaling , xBRZ is beautiful.

RE: Is jpcsp use 16 bit color depth defualt? - onelight - 01-17-2014

find A XBRZ filter plugin for JPCSP. code https://github.com/shenweip/XBRZ4JPCSP

RE: Is jpcsp use 16 bit color depth defualt? - Hykem - 01-17-2014

(01-17-2014, 11:29 AM)onelight Wrote: find A XBRZ filter plugin for JPCSP. code https://github.com/shenweip/XBRZ4JPCSP

This is really interesting. Do you think the author would mind if I added support for this plugin in JPCSP?
I could adapt the code and implement xBRZ in Java, but I think it would be nice to use this feature as a plugin.

RE: Is jpcsp use 16 bit color depth defualt? - onelight - 01-18-2014

(01-17-2014, 03:52 PM)Hykem Wrote:
(01-17-2014, 11:29 AM)onelight Wrote: find A XBRZ filter plugin for JPCSP. code https://github.com/shenweip/XBRZ4JPCSP

This is really interesting. Do you think the author would mind if I added support for this plugin in JPCSP?
I could adapt the code and implement xBRZ in Java, but I think it would be nice to use this feature as a plugin.

I think it is ok, you can added support for this plugin in JPCSP. But this plugin is Experimental, you need update it and fix some bug. You should also fix some bug in GVG next plus and Kingdom Hearts Birth by Sleep Final Mix.

RE: Is jpcsp use 16 bit color depth defualt? - Hykem - 01-18-2014

(01-18-2014, 08:29 AM)onelight Wrote:
(01-17-2014, 03:52 PM)Hykem Wrote:
(01-17-2014, 11:29 AM)onelight Wrote: find A XBRZ filter plugin for JPCSP. code https://github.com/shenweip/XBRZ4JPCSP

This is really interesting. Do you think the author would mind if I added support for this plugin in JPCSP?
I could adapt the code and implement xBRZ in Java, but I think it would be nice to use this feature as a plugin.

I think it is ok, you can added support for this plugin in JPCSP. But this plugin is Experimental, you need update it and fix some bug. You should also fix some bug in GVG next plus and Kingdom Hearts Birth by Sleep Final Mix.

I've added experimental support for XBRZ4JPCSP plugin in r3438. This will also be used for any other plugins we might develop or receive.
All that's needed is to copy the .dll inside the new plugins folder and paste it into the lib/[OS ARCHITECTURE] folder (same place as xuggler's .dll file).

As for the color issue, I'm still looking into it. Are there any settings that fix this? For example, does saving GE to textures also uses 16-bit or it gets translated to 32-bit? Thanks!

RE: Is jpcsp use 16 bit color depth defualt? - onelight - 01-19-2014

(01-18-2014, 05:58 PM)Hykem Wrote:
(01-18-2014, 08:29 AM)onelight Wrote:
(01-17-2014, 03:52 PM)Hykem Wrote:
(01-17-2014, 11:29 AM)onelight Wrote: find A XBRZ filter plugin for JPCSP. code https://github.com/shenweip/XBRZ4JPCSP

This is really interesting. Do you think the author would mind if I added support for this plugin in JPCSP?
I could adapt the code and implement xBRZ in Java, but I think it would be nice to use this feature as a plugin.

I think it is ok, you can added support for this plugin in JPCSP. But this plugin is Experimental, you need update it and fix some bug. You should also fix some bug in GVG next plus and Kingdom Hearts Birth by Sleep Final Mix.

I've added experimental support for XBRZ4JPCSP plugin in r3438. This will also be used for any other plugins we might develop or receive.
All that's needed is to copy the .dll inside the new plugins folder and paste it into the lib/[OS ARCHITECTURE] folder (same place as xuggler's .dll file).

As for the color issue, I'm still looking into it. Are there any settings that fix this? For example, does saving GE to textures also uses 16-bit or it gets translated to 32-bit? Thanks!

As for the color issue
Use only GE graphics (32-bit but blinks)

Enable saving GE to textures

XBRZ4JPCSP plugin not work

JPCSP

PPSSPP

And shenweip want to tell you, some bug need fix
https://github.com/hrydgard/ppsspp/issues/4408
https://github.com/hrydgard/ppsspp/commit/58860158dfcf67fc8d8dcfdae623b4e0921613e9

@shenweip @gid15
may be the light and shadow is the big problem which jpcsp need fix
JPCSP

JPCSP (save stencil to Memory)

PPSSPP (Buffered rendering)

RE: Is jpcsp use 16 bit color depth defualt? - hlide - 01-19-2014

(01-17-2014, 03:52 PM)Hykem Wrote:
(01-17-2014, 11:29 AM)onelight Wrote: find A XBRZ filter plugin for JPCSP. code https://github.com/shenweip/XBRZ4JPCSP

This is really interesting. Do you think the author would mind if I added support for this plugin in JPCSP?
I could adapt the code and implement xBRZ in Java, but I think it would be nice to use this feature as a plugin.

XBRZ in java !? I don't dare to think it may run fast this way.

RE: Is jpcsp use 16 bit color depth defualt? - Hykem - 01-20-2014

(01-19-2014, 10:18 PM)hlide Wrote:
(01-17-2014, 03:52 PM)Hykem Wrote:
(01-17-2014, 11:29 AM)onelight Wrote: find A XBRZ filter plugin for JPCSP. code https://github.com/shenweip/XBRZ4JPCSP

This is really interesting. Do you think the author would mind if I added support for this plugin in JPCSP?
I could adapt the code and implement xBRZ in Java, but I think it would be nice to use this feature as a plugin.
XBRZ in java !? I don't dare to think it may run fast this way.

Hehe, indeed. A lot of the texture scaling and filtering algorithms are too demanding for Java. This plugin approach gives much better results.

@onelight: Sorry, I forgot to mention the plugin is still disabled (internally), since I was still researching some graphical issues.

Also, I've found out what's going on with the 16-bit color depth, but I need to discuss it with gid first before making any changes.
Turns out we're correctly handling the textures in 32-bit format (internal format), but in the final frame buffer update (line 309 in sceDisplay) the sub texture being set (setTexSubImage at line 1698) is 16-bit (in Kingdom Hearts case).
In fact, if you comment out that portion of code you can see that the underlying texture is indeed 32-bit. While glTexImage2D uses an internal format (defined by us to be 32-bit), glTexSubImage2D doesn't and relies on the pixel format we are passing.

RE: Is jpcsp use 16 bit color depth defualt? - Hykem - 01-20-2014

xBRZ plugin has been enabled in r3440. The instructions are in the included README file. Smile

RE: Is jpcsp use 16 bit color depth defualt? - onelight - 01-21-2014

xBRZ now work,

but you must enable xBRZ before you load UMD, or xBRZ not work, and every will be crush

If you disbale xBRZ after you enabe xBRZ and run jpcsp, xBRZ still work

it is slow when CG video is play,

I thik use xBRZ in CG video is wrong, xBRZ should just use in subtitle