(08-01-2011, 04:01 AM)soywiz Wrote: Also, implementing the VFIM instruction I have seen that you are storing the output as if it was VD. But the register number is getted from the place of the VT register. It is really using the VD register? Because if not, prefixes could get wrong. Probably the VD in a different offset, but I wanted to be sure and to avoid headaches in the future. We can also make a test for all the vfpu missing stuff including that. Testing all the instructions, with all the special cases, with prefixes and for example verifying that prefixes only affects to one instruction...
VFIM and VIIM are very special instructions : the destination register is in the VT field but prefixes vpfxs and vpfxt are stated to have no effect on those instructions. However prefix vpfxd is stated to be valid. So we get the register index from VT field but handle it as it is a VD register so we may apply vpfxd on it.
But you're right, they need some tests with prefixes to assert or not those states.