Atrac3+ decoding with HiMDRenderer suggestion

[Itaru]

Is it solved in r1889?

Thank you for reporting!

Yup, both problems have been fixed in r1890. Crisis Core FFVII is running perfectly now with complete sound and music. Awesome work and many thanks!

[Itaru]

Oh well, I spoke too soon in my previous post. I'm still getting the NullPointerException in Crisis Core FFVII at line 681 in class jpcsp.HLE.modules150.sceAtrac3plus in method sceAtracSetDataAndGetID() whenever Zack does a limit break. It happens in r1890 and r1891. It also happens in r1892 after messing with the source code a bit to get it to compile and not hang in FFVII.

However, I think I can safely say that the IllegalArgumentException in OMAFormat has been completely fixed though.

[gid15]

Here's a workaround to get rid of the noise during decoding of Atrac3+ using HiMDRenderer in Jpcsp: just use nircmd ( http://www.nirsoft.net/utils/nircmd.html ) to mute the sound during the decoding. Extract nircmd into the lib\windows-x86 folder and edit the DecodeAudio.bat file.

The DecodeAudio.bat should look like this:

lib\windows-x86\nircmdc mutesysvolume 1
lib\windows-x86\HIMDRENDER -e -i %1 -o %2
lib\windows-x86\nircmdc mutesysvolume 0

The suggestion has been implemented in r1920. Thank you for the idea!

[Kai3213]

Here's a workaround to get rid of the noise during decoding of Atrac3+ using HiMDRenderer in Jpcsp: just use nircmd ( http://www.nirsoft.net/utils/nircmd.html ) to mute the sound during the decoding. Extract nircmd into the lib\windows-x86 folder and edit the DecodeAudio.bat file.

The DecodeAudio.bat should look like this:

lib\windows-x86\nircmdc mutesysvolume 1
lib\windows-x86\HIMDRENDER -e -i %1 -o %2
lib\windows-x86\nircmdc mutesysvolume 0

The suggestion has been implemented in r1920. Thank you for the idea!

The decoding sound is still there...at least in some games might I add.

[Itaru]

The suggestion has been implemented in r1920. Thank you for the idea!

You're very welcome and thanks for adding it to the svn.

The decoding sound is still there...at least in some games might I add.

Check whether the nircmdc command actually mutes the sound on your computer. Just play any music file then run the "nircmdc mutesysvolume 1" from the command prompt to check.

[hyakki]

the build bot builds, didn't include the nircmd files., so that's probably why it didn't mute

[Darth1701]

the build bot builds, didn't include the nircmd files., so that's probably why it didn't mute

I just assume it has something to do with false virus warnings. The Nirsoft utilities are often categorized as "potential unwanted program". But only Orphis can clear this up entirely.

[hyakki]

just noticed himdrender includes the source (why didn't I notice this before).

here is a modified version of himdrender i made, compiled /w vs2008 see below for changes.
I fixed the WER (windows error reporting) error some audio would get (the annoying "Himdrender has stopped working..." error) this way if himd gets a bad file, instead of crashing it won't do anything.

Code:

igraph->Connect(omgsrc_ipinout,omgtrns_ipinin)
->
igraph->ConnectDirect(omgsrc_ipinout, omgtrns_ipinin, NULL)

other changes made
1. Replaced the connect function (it would cause an 'wer' error popup when trying to decode bad/non decode-able files)
2. Removed some un-necessary dialogs (file browser popup, press a key to exit pause)
3. Added in its own mute function so it will mute (mutes himdrender.exe only) when decoding starts, and un-mute when done, this way jpcsp can always have un-muted audio, and no noise on decode., no longer needs nircmd

I tested with windows 7 and everything is working for me, I couldn't test the mute function on older systems (xp, 2000) so it still needs some tests from other people but it should work.
don't forget to remove the nircmd lines in the bat file. if you try this.

let me know what you think.

[Darth1701]

just noticed himdrender includes the source (why didn't I notice this before).

here is a modified version of himdrender i made, compiled /w vs2008 see below for changes.
I fixed the WER (windows error reporting) error some audio would get (the annoying "Himdrender has stopped working..." error) this way if himd gets a bad file, instead of crashing it won't do anything.

Code:

igraph->Connect(omgsrc_ipinout,omgtrns_ipinin)
->
igraph->ConnectDirect(omgsrc_ipinout, omgtrns_ipinin, NULL)

other changes made
1. Replaced the connect function (it would cause an 'wer' error popup when trying to decode bad/non decode-able files)
2. Removed some un-necessary dialogs (file browser popup, press a key to exit pause)
3. Added in its own mute function so it will mute (mutes himdrender.exe only) when decoding starts, and un-mute when done, this way jpcsp can always have un-muted audio, and no noise on decode., no longer needs nircmd

I tested with windows 7 and everything is working for me, I couldn't test the mute function on older systems (xp, 2000) so it still needs some tests from other people but it should work.
don't forget to remove the nircmd lines in the bat file. if you try this.

let me know what you think.

Great work, hyakki!

I just tested it with XP and it works very good, no noises during converting (without nircmd) and the annoying crashes are gone. Of course the crashes are not the fault of HiMDRenderer but they were annoying nonetheless.

[Itaru]

Yup, it's working great on my XP 64-bit. Awesome work, hyakki. Hopefully your version of HiMDRenderer will be implemented in the latest svn soon.