This forum uses cookies
This forum makes use of cookies to store your login information if you are registered, and your last visit if you are not. Cookies are small text documents stored on your computer; the cookies set by this forum can only be used on this website and pose no security risk. Cookies on this forum also track the specific topics you have read and when you last read them. Please confirm whether you accept or reject these cookies being set.

A cookie will be stored in your browser regardless of choice to prevent you being asked this question again. You will be able to change your cookie settings at any time using the link in the footer.

Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Savage Moon [NPUA80228]
#9
(01-11-2017, 01:04 AM)ssshadow Wrote: So for the record I just very roughly stubbed cellMusic, let every "set" function return cell_music_ok and some "get" functions return some BS data, like "music is currently not playing", per the docs.

So... why throw an exception instead?

Good point. I also think a LOG_ERROR would suffice for these kinds of unimplemented functions especially if they dont affect the games too greatly. If the hacks aren't too nasty I think you can submit a pull request into master.
Reply


Messages In This Thread
Savage Moon [NPUA80228] - by LittleGrejmer - 03-20-2014, 04:45 PM
RE: Savage Moon [NPUA80228] - by Annie - 03-04-2016, 08:34 PM
RE: Savage Moon [NPUA80228] - by aakh1361 - 01-10-2017, 06:24 PM
RE: Savage Moon [NPUA80228] - by ssshadow - 01-10-2017, 06:49 PM
RE: Savage Moon [NPUA80228] - by aakh1361 - 01-10-2017, 08:47 PM
RE: Savage Moon [NPUA80228] - by ssshadow - 01-10-2017, 09:58 PM
RE: Savage Moon [NPUA80228] - by aakh1361 - 01-10-2017, 11:50 PM
RE: Savage Moon [NPUA80228] - by ssshadow - 01-11-2017, 01:04 AM
RE: Savage Moon [NPUA80228] - by kd-11 - 01-11-2017, 10:41 AM
RE: Savage Moon [NPUA80228] - by BlackDaemon - 01-29-2017, 04:56 AM
RE: Savage Moon [NPUA80228] - by eoiz - 06-04-2017, 02:43 PM
RE: Savage Moon [NPUA80228] - by Annie - 06-05-2017, 02:06 PM
RE: Savage Moon [NPUA80228] - by eoiz - 06-05-2017, 06:52 PM
RE: Savage Moon [NPUA80228] - by eoiz - 06-10-2017, 11:42 PM

Forum Jump:


Users browsing this thread: 1 Guest(s)