r2459 broke Enable VAO?

[BlackDaemon]

I'm noticed, when i'm trying to load some games (like God of War: Chains of Olympus/Prince of Persia: Rival Swords) with "Use shaders" + "Use vertex cache" + "Enable VAO" compatibility options i got JVM crashed. On r2458 it works ok.

Could anyone confirm/refute this? Thanks!

Code:

#
# A fatal error has been detected by the Java Runtime Environment:
#
#  EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x655c7214, pid=2104, tid=3912
#
# JRE version: 7.0_03-b05
# Java VM: Java HotSpot(TM) Client VM (22.1-b02 mixed mode windows-x86 )
# Problematic frame:
# C  [nvoglv32.DLL+0x757214]
#
# Failed to write core dump. Minidumps are not enabled by default on client versions of Windows
#
# An error report file with more information is saved as:
# D:\eclipse\workspace\Jpcsp\hs_err_pid2104.log
#
# If you would like to submit a bug report, please visit:
#   http://bugreport.sun.com/bugreport/crash.jsp
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#

[MaXiMu]

you try with If Enable Dynamic shader generation On ? I Solved for me

[BlackDaemon]

Thanks for hint, MaXiMu! Unfortunately, it's an half-solution for me, because i've got black screen instead of Intros/Videos, and invisible Menu/GUI in God of War: Chains of Olympus. But there also the good news - i've got Twisted Metal: Head On running stable ingame! (unfortunately, it breaks some cars graphics )

[gid15]

I'm noticed, when i'm trying to load some games (like God of War: Chains of Olympus/Prince of Persia: Rival Swords) with "Use shaders" + "Use vertex cache" + "Enable VAO" compatibility options i got JVM crashed. On r2458 it works ok.

By doing a code review of r2459, I have found a problem with the handling of VAO. Could you try again with r2505?

Thank you for the regression tests!

[BlackDaemon]

gid15,

It works fine now, thanks for fixing!

Edit: Yay, JVM crash in Twisted Metal: Head On is also fixed!